search

corazawaf / coraza-spoa

EXPERIMENTAL: A wrapper around the OWASP Coraza WAF for HAProxy's SPOE filters
Apache License 2.0
74 stars 16 forks source link

upgrade coraza to v3.0.3 #84

Open jptosso opened 11 months ago

jcchavezs commented 11 months ago

@M4tteoP e2e seems stuck here. Could you please migrate to new e2e?

M4tteoP commented 11 months ago

Tried to give it a go here: https://github.com/corazawaf/coraza-spoa/pull/85. Still a WIP, it is currently failing. What I notice is that the e2e test started failing from the latest commit of https://github.com/corazawaf/coraza-spoa/pull/72, but I can't find anything obvious that originated this problem. cc @sts

zc-devs commented 11 months ago

Perhaps, it's because of no_response_check: true. If yes, you can pick up fixes from here.

jcchavezs commented 11 months ago

Up for a PR?

On Mon, 21 Aug 2023, 21:02 Thomas Anderson, @.***> wrote:

Perhaps, it's because of no_response_check: true https://github.com/corazawaf/coraza-spoa/blob/6a0d9a3ba67379892eafa105c636d85016f8ef21/config.yaml.default#L22. If yes, you can pick up fixes from here https://gitea.smthd.com/mirko/coraza-spoa/commits/branch/main.

— Reply to this email directly, view it on GitHub https://github.com/corazawaf/coraza-spoa/pull/84#issuecomment-1686870940, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXOYARYQTS7FQWBLBTP473XWOWETANCNFSM6AAAAAA3YFZJMU . You are receiving this because you commented.Message ID: @.***>

zc-devs commented 11 months ago

Up for a PR?

Unfortunately, no. I'm quite busy now.

fzipi commented 6 months ago

@zc-devs Do you think it is a better time now to provide a PR?

zc-devs commented 6 months ago

Sorry, I've changed my mind towards Kubernetes. I'm running CrowdSec now and probably will deploy open-appsec. So, I've been not using Coraza SPOA since then.

Anyway, it should be this commit. Or just revert this setting.