search

corba22 / eggbotcode

Automatically exported from code.google.com/p/eggbotcode
0 stars 0 forks source link

EBB: Create separate set of commands that use 'correct' ms <duration> values, revert SM, SP, TP commands #69

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
In 2.2.1, the SM, SP and TP commands were 'fixed' with regards to their 
<duration> parameter, which (previously) was in units of 1/25KHz. The docs said 
it should be in ms. So that was fixed in 2.2.1.

However, this may cause incompatibilities with existing applications that send 
data to the EBB.

So instead, create an alternate set of SM, SP and TP commands that use the 
proper ms <duration> values, and revert SM, SP and TP commands to using 1/25KHz 
units for their <duration> values like before.

Original issue reported on code.google.com by brian.schmalz on 18 Oct 2013 at 11:59

GoogleCodeExporter commented 8 years ago 
This problem description is not quite correct. The SM command has always had 
<duration> parameter units of ms, and that is what the Inkscape extensions 
currently expect. The <duration> parameters for SP and TP were (are) never used 
by the Inkscape extensions, so it's not necessary to revert them to 40uS units 
rather than mS units.

Unless there's a good reason to be able to use either 1mS or 40uS units for the 
SP and TP commands, I'm going to leave them at 1mS units and close this issue 
as not needing any changes.

Original comment by brian.schmalz on 27 Apr 2014 at 12:38