corbado / javascript

MIT License
6 stars 1 forks source link

Split Playwright tests into two groups #325

Closed incorbador closed 1 day ago

incorbador commented 2 weeks ago

Why

Running all e2e tests on every commit to a PR takes too much time and resources. It would be better to split the existing set of tests into two groups:

  1. runs every commit to a PR
  2. runs every night

TODOS

aehnh commented 2 weeks ago

https://ray.run/blog/organizing-playwright-tests-using-tags

I can tag specific tests and run only those on CLI command.

I still need to check how I can limit these tests to run only for Chrome.

aehnh commented 1 week ago

There is no way to use tags to specify browsers. However, it seems reasonable to remove any browser specifications from the config file and simply specify browsers for the entire test set from CLI command. The downside would be that the nightly tests would take slightly longer (because even tests that were originally intended to be run on only chromium would run on every browser) but taking 20 minutes instead of 15 minutes for each nightly run seems rather trivial

aehnh commented 1 week ago

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#schedule

Github cron jobs run only on the last commit of the default branch (develop on corbado/javascript repo)

aehnh commented 1 week ago

Keeping it at in-progress until I confirm that the nightly workflow runs properly on develop branch

aehnh commented 1 week ago

Also need to search about slack notifications

aehnh commented 1 week ago

https://github.com/marketplace/actions/slack-send

aehnh commented 4 days ago

https://github.com/ryanrosello-og/playwright-slack-report