Fix submit functionality in LoginInitScreen - Githubissues

corbado / javascript

MIT License

7 stars 2 forks source link

Fix submit functionality in LoginInitScreen #344

Closed incorbador closed 3 weeks ago

incorbador commented 3 weeks ago

Describe the bug Change from #332 broke the functionality that a user can submit the form by pressing enter on the LoginInit screen. Now instead of submitting the form, the input will switch to it's phone version. This is the case because the SecondaryButton now also is a button instead of a span.

To Reproduce Go to https://develop.react.playground.corbado.io/pro-6698593986287122356/auth#signup-init, focus the input field, provide a value and press enter.

Expected behavior Pressing enter should submit the form again. Two options:

we revert the change
we keep the change but adapt the screen (we have to check for other screens as well though) => this might now be so easy (see for example https://stackoverflow.com/questions/1963245/multiple-submit-buttons-on-html-form-designate-one-button-as-default)