Closed aehnh closed 3 weeks ago
as-is: only display components if the user has identifier to-be: display components if project supports identifier. If user doesn't have the identifier, add an option to add it
Need to add a new public frontend api v2 endpoint that returns which identifier types (+ full name) are enabled?
Options:
At first I thought the updated @corbado/types code needs to be published to npm registry, but it seems the issue is bigger than that:
Simply using LoginIdentifierType from packages/react breaks the lerna build command. If I add @corbado/types to packages/react/webpack.prod.js and packages/web-js/tsconfig.bundler.json, lerna build is fixed but running react playground fails.
Since everything works correctly outside this branch, it seems that modifying interdependent packages (react, shared-ui, types) simultaneously seems to cause the problem. Is there a best-practice for this that i'm not aware of?
At first I thought the updated @corbado/types code needs to be published to npm registry, but it seems the issue is bigger than that:
Simply using LoginIdentifierType from packages/react breaks the lerna build command. If I add @corbado/types to packages/react/webpack.prod.js and packages/web-js/tsconfig.bundler.json, lerna build is fixed but running react playground fails.
Since everything works correctly outside this branch, it seems that modifying interdependent packages (react, shared-ui, types) simultaneously seems to cause the problem. Is there a best-practice for this that i'm not aware of?
It works when I use LoginIdentifierType from shared-ui instead of from corbado/types... why??? :(
[ ] Improve the UI together with @Dopeamin => TODO: make a list of required changes
[x] Check for usage of translations (compare with PasskeyList)
[ ] Include into previewui
[ ] Think about documentation in README.mds of the javascript repo and in docs.corbado.com (compare with PasskeyList)
[ ] Think about pentesting
todos for changes to the UI
as-is: only display components if the user has identifier to-be: display components if project supports identifier. If user doesn't have the identifier, add an option to add it