Closed Aby-JS closed 6 months ago
Here are my few thoughts and pointers I think we should discuss in our meeting:
core/
. One would be CorbadoApp
and other called CorbadoSDK
.CorbadoApp
: This could be a base class that provides common functionality required by all implementations of our react
, angular
, vue
etc frameworks. The purpose of this class is to make it easier for devs to create a new SDK + Complete App package without getting into details of flows, session handling, etc.CorbadoSDK
: This would be the interface for developers, exposing only the necessary services and utilities they need to build upon. This would not need to use FlowHandlerService, will be allowing developers to use their own session management service which would just need to followr our ISessionManagement interface and would allow for other flexibilities.I think be separating these two cases into two separate classes we can then give all flexibility to the users who wants it by using our framework specific SDKs and still generalize all the common logic that our framework specific complete packages needs to implement including flows, session management, etc.
This is the PR for that ticket: https://github.com/corbado/javascript/pull/52 (it includes a description about the changes)
@incorbador we need to add details to this ticket about the expected changes after our discussion.