corbado / javascript

MIT License
7 stars 2 forks source link

Enhancing Library Structure through Strategic Package Publishing #83

Closed Aby-JS closed 5 months ago

Aby-JS commented 6 months ago

Why

To streamline the development and release workflow of our multi-package library, including types, web-core, shared-ui, react-sdk, and react, we need to establish a more structured package publishing approach. This initiative will help to standardize the versioning process, manage dependencies more effectively, and ensure that each package is optimally tailored for end-user consumption, thereby enhancing the overall quality and usability of our library.

TODO

Acceptance Criteria

Implementation Idea

Aby-JS commented 6 months ago

Future plans:

incorbador commented 6 months ago

@Aby-JS Can you please update the issue to include the sections (why, todo, acceptance criteria, implementation idea) from our issue template (Stefan has proposed it a few weeks ago, we also use it in our "corbado" repository)?

I would put the points from the current acceptance criteria section in the the todo section. To me, acceptance criteria for this ticket could look like this:

Aby-JS commented 6 months ago

@incorbador the ticket has been refactored to follow the pattern.

incorbador commented 6 months ago

I think we should also demonstrate here how we would publish to npmjs (from my point of view this is the most important point of this ticket because it proves that have done all the most must-haves to be able to publish to npm). Therefore I think, this should be part of the AC (acceptance criteria), so I would add "packages can be published to npmjs.com via a single command (we can publish alpha versions for now)".

Aby-JS commented 6 months ago

"packages can be published to npmjs.com via a single command (we can publish alpha versions for now

done