search

corbanmailloux / esp-mqtt-rgb-led

MQTT RGB LEDs Using JSON for Home Assistant
MIT License
270 stars 74 forks source link

Brightness transitions can overshoot. #6

Open corbanmailloux opened 7 years ago

corbanmailloux commented 7 years ago

If I have a light set to brightness: 255 and color: 33, 255, 19, and then I fade it to brightness: 40 with a transition of 1, it seems to overshoot and I end up with a very dim purple.

If I send the same request again, the lights set to the correct value.

corbanmailloux commented 6 years ago

I would think that this is caused by something with the comparison here. I haven't looked into it yet, but maybe the lastLoop isn't being set correctly for short transition times.

eldoner commented 6 years ago

https://github.com/bruhautomation/ESP-MQTT-JSON-Digital-LEDs/issues/15