search

corbin-hayden13 / SD-Lora-Tagger

A Search Engine For All Your Local Extra Networks (in AUTOMATIC1111/stable-diffusion-webui and vladmandic/automatic)
MIT License
11 stars 2 forks source link

Incompatibility with CivitAI Helper Extension #24

Closed corbin-hayden13 closed 5 months ago

corbin-hayden13 commented 5 months ago

Having both extensions loaded crashes the helper and the helper buttons no longer work as intended.

See this comment for more details.

Unconfirmed at this point

Cruxial0 commented 5 months ago

I am able to reproduce. The error seems to lie in the file path having a comma added to the end of it: image

corbin-hayden13 commented 5 months ago

Thanks for confirming @Cruxial0 I'll work on a patch for it

corbin-hayden13 commented 5 months ago

I found the issue: Civitai is searching for the model filename from the search_term of the file, but because we override the search_term, it wasn't splitting the text properly on civitai's end and was adding the comma because our search_term is comma-delimited. I'm gonna try and patch this by adding appending the filename of the extra networks to the front of the search_term and including a space like so: f"{model.filename} {our_search_terms}|||{extras}"

Cruxial0 commented 5 months ago

I know what the issue is but I'm not able to recreate the error message you got, what process did you go through to do that? I need to test if the patch I implemented worked or not.

I got it by clicking any of the 4 buttons that the extension adds to the lora cards. If it adds something to the prompt, then it should be working properly.

corbin-hayden13 commented 5 months ago

Sounds good, I was was using SDNext instead of the default stable-dffusion-webui, the model card buttons aren't on SDNext. I fixed it and will be merging the corresponding pr shortly.