search

corbindavenport / imageshare

A lightweight web app for uploading images, created for the Nintendo 3DS and other legacy web browsers.
https://theimageshare.com
GNU General Public License v3.0
83 stars 5 forks source link

Changing 3ds game detection to be more accurate #22

Closed spaghefoo closed 2 months ago

spaghefoo commented 7 months ago

Hello, While working on another python project similar to this(instead of publishing to imgbb and imgur it publishes to mastodon basically), i noticed that the 3dsreleases.xml file used here is partially wrong, As i checked the software exif values of images from my 3ds and it didn't hit.(notably pokémon rumble world and smash bros didn't hit and team kirby clash deluxe had a different title id for some reason). Also not all regions were supported.

I found a github that provided jsons and xml( https://github.com/hax0kartik/3dsdb ) that got it's values from nintendo eshop server directly for all regions so it's more accurate and i implemented them here.

Thank you

corbindavenport commented 7 months ago

Nice, I'll check this out when I get some free time. It might make more sense to pull directly from that repo during the build process instead of bundling all the game lists in the ImageShare repository, but I'll have to check what's possible there.

corbindavenport commented 2 months ago

Thanks for this! I added a check so the EXIF code doesn't run on unsupported file formats, otherwise PNG files show an error.

I tried screenshots from Pokemon X, Smash Bros, and 3D World, and they all seemed to work. Animal Crossing screenshots don't show the game title anymore, though. This is an overall improvement so I'm leaving this merged (and included it in the v24.06 release), but I opened #25 to look into the Animal Crossing issue and possibly other missing titles.