corbindavenport / imageshare

A lightweight web app for uploading images, created for the Nintendo 3DS and other legacy web browsers.
https://theimageshare.com
GNU General Public License v3.0
83 stars 5 forks source link

Improve 3DS game handling #25

Open corbindavenport opened 2 months ago

corbindavenport commented 2 months ago

Animal Crossing screenshots don't work after #22 was merged. It might also make sense to move the game lists out of the code repository, or at least make it easily synchronized with the original source.

spaghefoo commented 1 month ago

could you give me an animal crossing jpg screenshot from a 3ds? i don't have the game to test this one...

corbindavenport commented 1 month ago

The sample image in the repo has the metadata: https://github.com/corbindavenport/imageshare/blob/main/sample.jpg

spaghefoo commented 1 month ago

After checking yesterday, the titleID associated with the image was actually pointing on an update. We didn't check for updates titleIDs(which have a distinct titleID pattern) because when writing the code i thought "we don't need to check for game updates it's only games we are interested in.". It seems like animal crossing proved me wrong somehow. now it works for animal crossing, however it shows as "Animal Crossing™: New Leaf Update Ver. 1.5". I also encounted an other(small) issue where when uploading some game images(Pokémon sun for example) it would show as : Update. I modifed the code a bit to fix that. I'll check for the json repo thing at a later date but the main issue is fixed now.