Update to corcel 3.0

[hebbet]

fixes #79

[zeroiszero]

travis build failed with the command mkdir -p build/logs in .travis.yml. May I know what is use of that ?

[hebbet]

travis build failed with the command mkdir -p build/logs in .travis.yml

Nope. the exit code of mkdir -p is 0, so successful.

mkdir -p creates folders, including the parent folder if it doesn't exist.

[zeroiszero]

@hebbet , I made another pull request #81 that will fix the travis build error (phpunit 8 compatibility)

[jgrossi]

@hebbet hey thanks for the hard work I fixed the Travis build on branch pr-80 that includes your changes on this PR plus required changed to make it working can you change the base the base branch from this PR to pr-80 please? it has your changes already thanks!

[hebbet]

when i try to change that, i get that error.

[zeroiszero]

@hebbet , i think you need to sync with the branch pr-80.

[jgrossi]

@hebbet this PR's base branch is your develop one. can you change that to another pr-80 branch? then I can push changes to it to update the PR and merge it here, thanks!

[hebbet]

I don't see an option for that

Junior Grossi notifications@github.com schrieb am Fr., 13. Sept. 2019, 15:36:

@hebbet https://github.com/hebbet this PR's base branch is your develop one. can you change that to another pr-80 branch? then I can push changes to it to update the PR and merge it here, thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/corcel/acf/pull/80?email_source=notifications&email_token=AAK3OCZI7XNS7MEXD3EJOZTQJOJMLA5CNFSM4IUZS6I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6VBFKI#issuecomment-531239593, or mute the thread https://github.com/notifications/unsubscribe-auth/AAK3OC4WS43IVLOXVDKLZYLQJOJMLANCNFSM4IUZS6IQ .

[jgrossi]

@hebbet ok gonna close this PR and raise another one based on pr-80 branch. thanks for the work