search

corcel / acf

Advanced Custom Fields (ACF) plugin for Corcel
126 stars 98 forks source link

Laravel 8 support #94

Closed squatto closed 3 years ago

squatto commented 3 years ago

This adds support for Laravel 8.x by way of adding support for Corcel 5.x (added by Corcel PR #531). The PHPUnit version constraints were changed to line up with Laravel 8's PHPUnit version constraints.

I based this branch on master because develop isn't in sync with master yet (#93 brings them in sync but it isn't merged yet)

squatto commented 3 years ago

This build fails because it's using PHP 7.2, and Laravel 8 requires >=7.3. I left >=7.2 as the PHP version constraint to allow Corcel 4.x to be used, and added a "PHP" column to the newly-added "Version Compatibility" section in the readme:

https://github.com/squatto/acf/blob/c01a5d4e5331a329df16e21d090886f7b3327667/readme.md#L22-L27

Version Compatibility

Corcel Laravel PHP
^4.0 7.x >=7.2
^5.0 8.x >=7.3

EDIT: I adjusted the travis builds to test v4 against 7.2, 7.3, and 7.4 and v5 against 7.3 and 7.4. All builds are passing now 👍🏻

squatto commented 3 years ago

If you can't tell, this is my first foray into Travis builds. Sorry for the barrage of commits and builds!!