corceslab / CHOIR

CHOIR : Clustering Hierarchy Optimization by Iterative Random forests (www.CHOIRclustering.com)
MIT License
20 stars 5 forks source link

replace seurat_object (a nonexistent object) with object #10

Closed agdenadel closed 6 months ago

agdenadel commented 6 months ago

When using CHOIR with a Seurat object from Seurat v5 I had this error

Error in .getMatrix.Seurat(object, use_matrix, use_assay, use_slot, use_features,  : 
  object 'seurat_object' not found
Calls: runDimReduction -> .getMatrix -> .getMatrix.Seurat

I noticed that seurat_object had never been defined and object was the name of the seurat object in the function call.

catpetersen commented 6 months ago

Thanks! Caught this as well--it's been fixed in the dev branch, commit 0c7272e, so I'll close this pull request. Will be fixed in the main branch soon.