search

corda / accounts

Accounts on Corda
Other
36 stars 38 forks source link

Don't Use Single Character Variable Names #29

Closed opticyclic closed 5 years ago

opticyclic commented 5 years ago

Using single character variable names makes the code harder to read and understand what is going on.

e.g. https://github.com/corda/accounts/blob/master/examples/tokens-integration-test/src/integrationTest/kotlin/com/r3/corda/lib/accounts/examples/tokensTest/IntegrationTest.kt#L122-L128

roger-that-dev commented 5 years ago

Generally I'd agree with you but in the case of these tests where we refer to nodes by A, B, C, etc. I think it's OK!