CORE-4355: CPK Format version 2

corda / corda-gradle-plugins

Gradle plugins used by Corda and Cordapps

Other

24 stars 36 forks source link

CORE-4355: CPK Format version 2 #510

Closed josephzunigadaly closed 2 years ago

josephzunigadaly commented 2 years ago

Change name of plugin to cordapp-cpk2/cordapp-cpb2

Rename cordapp-cpk folder to cordapp-cpk2
Rename net.corda.plugins.cordapp-cpk plugin id to net.corda.plugins.cordapp-cpk2
Rename net.corda.plugins.cordapp-cpb plugin id to net.corda.plugins.cordapp-cpb2
Rename cordapp-cpk.properties file to cordapp-cpk2.properties
Rename net.corda.plugins.cpb package to net.corda.plugins.cpb2
Rename net.corda.plugins.cpk package to net.corda.plugins.cpk2
Change cordapp-cpk to cordapp-cpk2 in readme and source files

josephzunigadaly commented 2 years ago

But why copy at all, when you could git mv ...? I was expecting the 6.0.0-BETAxx version to be built by the release/6.0 branch from now on

I would be happy with a move instead. I'll swap this PR to do a move.

chrisr3 commented 2 years ago

It has not been modified and is not included in gradle settings.

I'm not following you. Gradle will ignore all of these files unless you include cordapp-cpk2 in settings.gradle.

josephzunigadaly commented 2 years ago

It has not been modified and is not included in gradle settings.

I'm not following you. Gradle will ignore all of these files unless you include cordapp-cpk2 in settings.gradle.

Yes. I was going to do that in a follow up PR. So we didn't have to review a mix of copied and modified files. A move will be cleaner and most of that description becomes irrelevant.