search

corda / corda-solutions

Corda Solutions
28 stars 40 forks source link

Hardcoded table creation does not work on Oracle #67

Closed ing-rafbhoedjang closed 5 years ago

ing-rafbhoedjang commented 5 years ago

See https://github.com/corda/corda-solutions/blob/1af6bd2d47ac7502d8ffe822c1266f5b9d42f04b/bn-apps/memberships-management/membership-service/src/main/kotlin/com/r3/businessnetworks/membership/bno/service/DatabaseService.kt#L28

The DatabaseService issues a SQL query that does not work on Oracle 12. (Apparently, 'IF NOT EXISTS' is not a standardized feature.)

Is there any reason for not using a Liquibase migration script to create this table?

ischasny commented 5 years ago

Hi @ing-rafbhoedjang . Apologies for coming back late on this one. This has been fixed in the last version of BNMS (2.0). Please check it out.