A first PR, testing the waters. All of the changes here are cosmetic:
Formatting changes to eliminate unnecessary block syntax, and fix indent length to 4 spaces.
vals in test classes declared private. This may be overkill; the only purpose is to remove an IDE underline.
Changes to DriverBasedTest pulling out some utility functions in order to clarify intention in the test body. It may be that these functions are distracting and that it would be better to keep their functionality inline - my preference is for expressing tests in something as close as possible to a DSL fitted to the cases to be tested, but in this case the goal of introducing beginners to the framework should obviously be considered paramount.
Changes to FlowTests to eliminate lateinit, which is generally a bit of a smell. It may be that the init block is equally distasteful, and its contents should be moved inside the setup method.
joeldudley
commented
6 years ago
A first PR, testing the waters. All of the changes here are cosmetic:
vals in test classes declaredprivate. This may be overkill; the only purpose is to remove an IDE underline.DriverBasedTestpulling out some utility functions in order to clarify intention in the test body. It may be that these functions are distracting and that it would be better to keep their functionality inline - my preference is for expressing tests in something as close as possible to a DSL fitted to the cases to be tested, but in this case the goal of introducing beginners to the framework should obviously be considered paramount.FlowTeststo eliminatelateinit, which is generally a bit of a smell. It may be that theinitblock is equally distasteful, and its contents should be moved inside thesetupmethod.