corda / samples

This repository has been deprecated. Please use the links in the README to access the new repositories.
98 stars 150 forks source link

Serialization of whitelisted custom data classes without annotation in MockNetwork #105

Open MikkelThomsen opened 4 years ago

MikkelThomsen commented 4 years ago

Hi.

In https://github.com/MikkelThomsen/samples I have added an example of a contract that uses a custom data class and runs a MockNetwork using that class. See cordapp-example/workflows-kotlin/src/test/kotlin/com/example/test/contract/IOUContractTests.kt. The data class is whitelisted, but not annotated with @CordaSerializable.

When running the test, it fails with Class "class com.example.data.IOUData" is not on the whitelist or annotated with @CordaSerializable.'. If I annotate it, the test succeeds.

I have added a META-INF/services/net.corda.core.serialization.SerializationWhitelist with a reference to the class that extends SerializationWhitelist.

As far as i can see, JarScanningCordappLoader#findWhitelists checks whether the whitelist has the same location as the CorDapp, but the whitelist implementation is picked up from the classpath instead. The expected location is within the created mockNetwork folder and not the project classpath.

Is there something in either the gradle dependency setup or the whitelist specification that I am doing wrong?

Sincerely Mikkel

MikkelThomsen commented 4 years ago

It seems like it is the same issue we are facing in https://github.com/corda/corda/issues/5914

MikkelThomsen commented 4 years ago

It seems like this is the same issue: https://r3-cev.atlassian.net/browse/CORDA-3643