Negotiation CorDapp Missing a Time-window

corda / samples

This repository has been deprecated. Please use the links in the README to access the new repositories.

98 stars 150 forks source link

Open adelrustum opened 4 years ago

adelrustum commented 4 years ago

In the Negotiation CorDapp both ProposalState and TradeState belong to the same contract ProposalAndTradeContract.
Inside the contract, it mandates for Propose command that there should be a time-window (see here).
But proposalFlow (which uses Propose command for the transaction) doesn't add a time-window; so the transaction verification would definitely fail (see here).
Btw, the above mentioned flow doesn't call tx.verify() before signing the transaction (see here).

adelrustum commented 4 years ago

Update: AcceptanceFlow and ModificationFlow don't add a time-window either; even though it's required by the contract.