search

cordawyn / spira

Fork of Spira with experimental branches, occasionally merged upstream.
http://blog.datagraph.org/2010/05/spira
The Unlicense
8 stars 2 forks source link

Remove last Set occurences + Update spec_helper #11

Closed abrisse closed 11 years ago

cordawyn commented 11 years ago

I deliberately left "types" to be an instance of Set - we do not need duplicates there. Although the same idea should've been applied to has-many relations, I had to make them Arrays so as to avoid automatic evaluation of "promised" values whenever a member is added to the set.

So, unless you have a use case where types should rather be an Array, I'll reject this pull request.

abrisse commented 11 years ago

OK you need the require 'set' line removed in your previous commit back then.

cordawyn commented 11 years ago

Oops :-) Thanks!