Add new types - Githubissues

cordawyn / spira

Fork of Spira with experimental branches, occasionally merged upstream.

http://blog.datagraph.org/2010/05/spira

The Unlicense

8 stars 2 forks source link

Add new types #17

Closed abrisse closed 11 years ago

abrisse commented 11 years ago

Add new types 'long', 'nonNegativeInteger', 'nonPositiveInteger,' 'negativeInteger'
Fix some typo on some spec

Signed-off-by: Aymeric Brisse aymeric.brisse@perfect-memory.com

cordawyn commented 11 years ago

Looks OK, thank you! Could you merge it with the head of cordawyn/activemodelish so that I could accept it using github button?

cordawyn commented 11 years ago

Btw, there was a commit already, introducing RDF:: namespace for datatypes: https://github.com/cordawyn/spira/commit/0503306e7ef72a1fb1e066f9213ad359846cadcb I'm not sure if it actually served a good purpose then.

gkellogg commented 11 years ago

Note that the rdf-xsd gem implements most of these datatypes.

cordawyn commented 11 years ago

@gkellogg Then it probably makes sense to get rid of types in Spira? I suggest that we make a release of Spira with what we have now (including this pull request and perhaps postponing the one with localized strings), and then try integrating rdf-xsd with Spira.

gkellogg commented 11 years ago

Sure, just tag the commit with the release number and update VERSION accordingly and I'll push it out when you're ready.