search

cordova-plugin-camera-preview / cordova-plugin-camera-preview

Cordova plugin that allows camera interaction from HTML code
MIT License
567 stars 559 forks source link

[Fix] Custom UI overlain #676

Closed ghost closed 1 year ago

ghost commented 1 year ago

This pull request aims to fix custom UI elements being overlain by the plugin view. Without this change, the plugin view is always brought to the front and essentially hides any custom UI elements.

Here are the options we used:

const options: CameraPreviewOptions = {
    camera: this.cameraPreview.CAMERA_DIRECTION.BACK,
    width: window.innerWidth,
    height: window.innerHeight,
    tapFocus: true,
    tapPhoto: false,
    toBack: true,
    alpha: 1,
};
westonganger commented 1 year ago

Awesome thank you for contribution! Kudos especially for changing the iOS code too!

westonganger commented 1 year ago

https://github.com/cordova-plugin-camera-preview/cordova-plugin-camera-preview/issues/677#issuecomment-1204384546

@thrnjica seems like your PR #676 caused this, can you comment here. What xcode/ios versions did you test with?

Since there are issues with the IOS portion of this contribution I have rolled back the IOS changes in https://github.com/cordova-plugin-camera-preview/cordova-plugin-camera-preview/commit/f2839635a7c569ed5d9659737e692406e84a23d9