cordova-plugin-facebook-connect / cordova-plugin-facebook-connect

Use the latest Facebook SDK in your Cordova and Ionic projects
Other
63 stars 90 forks source link

Info plist is not filled properly on iOS #97

Closed marioshtika closed 1 year ago

marioshtika commented 2 years ago

Bug or feature request

[x] I'm reporting a reproducible issue with the code [ ] I'm reporting a feature request

Describe the Bug of feature request

The *-info.plist file is not filled with the right values

Expected Behavior

I would expect the below variable and value

<key>FacebookAdvertiserIDCollectionEnabled</key>
<string>false</string>

Instead, I am getting the below variable and value

<key>FacebookAdvertiserIDCollectionEnabled_PLACEHOLDER</key>
<string>FACEBOOK_ADVERTISER_ID_COLLECTION_PLACEHOLDER</string>

Plugin version, OS, devices, etc

Plugin version: 3.2.0 Test on iOS versions: iOS 14.5+ Tested on devices: iPhone XR & iPhone 11 also in the emulator

Additional Context

Hello and thank you for supporting this plugin.

I am going to send some screenshots that might help you better understand the issue.

This is a screenshot from the info tab on xCode: xcode

This is a screenshot from the uploading process: upload

Thank you in advance

marioshtika commented 2 years ago

If you need anything from me, either with testing or sending a pull request, just let me know.

marioshtika commented 1 year ago

I found out, why this was happening. I am putting this here, in case it helps someone else.

I was using the config-file on the config.xml file of the project (to change something on the plist file, not related to this plugin) and I found out that the config-file option should be used only on the plugins configuration, not on the config.xml.

That was messing with a lot of my Cordova plugins, which was preventing the plugins from changing the plist file as they should.

Remove all your config-file from the config.xml and check if that fixes this problem.

Tip: If you need to change the plist, try writing hooks using Node.js as shown in the Cordova documentation.