search

cordova-rtc / cordova-plugin-iosrtc

Cordova iOS plugin exposing the WebRTC W3C API
MIT License
688 stars 341 forks source link

[Announcement] cordova-plugin-iosrtc Version 7.0.x notes #469

Closed hthetiot closed 3 years ago

hthetiot commented 4 years ago

Hello cordova-rtc users,

I will released cordova-plugin-iosrtc 7.0.0 but in the mean time 7.0.0-RC4 is available for testing.

The current work in progress is on the branch https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/7.0.0 and the PR is https://github.com/cordova-rtc/cordova-plugin-iosrtc/pull/475

Changelog Version 7.0.0

Test 7.0.0-RC3

cordova plugin remove cordova-plugin-iosrtc --verbose cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/7.0.0 --verbose cordova platform remove ios --no-save cordova platform add ios@latest --no-save

Capture

Tested on iOS 12.4.5 on iPhone 6.

Image from iOS (1)

hthetiot commented 4 years ago

WebRTC M75 Release Notes: https://groups.google.com/forum/m/?utm_medium=email&utm_source=footer#!msg/discuss-webrtc/_jlUbYjv-hQ/mCtjlVyjAgAJ

hthetiot commented 4 years ago

7.0.0-RC3 available for testing based on 6.0.12 changes. See: https://github.com/cordova-rtc/cordova-plugin-iosrtc/issues/425#issuecomment-633273070

cordova plugin remove cordova-plugin-iosrtc --verbose cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#7.0.0-RC3 --verbose

numerized commented 4 years ago

Hi here, testing RC2 ok so far, thanks a lot! RC3 gives me this:


Set IPHONEOS_DEPLOYMENT_TARGET to "11.0".
iOS Product Name has not changed (still "Bandcast")
Updating icons at platforms/ios/Bandcast/Images.xcassets/AppIcon.appiconset/
Updating launch storyboard images at platforms/ios/Bandcast/Images.xcassets/LaunchStoryboard.imageset/
Updating Storyboard image set contents.json
This app does not have additional resource files defined
Prepared iOS project successfully
Executing script found in plugin cordova-plugin-add-swift-support for hook "after_prepare": plugins/cordova-plugin-add-swift-support/src/add-swift-support.js
Executing script found in plugin cordova-plugin-iosrtc for hook "after_prepare": plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js
Cannot read property '1' of null
TypeError: Cannot read property '1' of null
    at getProjectName (/Users/redloko/00_Github/bandcast/plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js:35:56)
    at module.exports (/Users/redloko/00_Github/bandcast/plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js:131:17)
    at runScriptViaModuleLoader (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:181:32)
    at runScript (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:157:16)
    at /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:125:20
    at processTicksAndRejections (internal/process/task_queues.js:97:5)
[ERROR] An error occurred while running subprocess cordova.

        cordova platform add ios@latest --verbose exited with exit code 1.

        Re-running this command with the --verbose flag may provide more information.
  ionic:utils-process onBeforeExit handler: 'process.exit' received +0ms
  ionic:utils-process onBeforeExit handler: running 1 functions +0ms
  ionic:utils-process processExit: exiting (exit code: 1) +37ms```
hthetiot commented 4 years ago

Thank you @numerized we will fix or update minimal iOS target requirements.

Your help is appreciated.

numerized commented 4 years ago

sure let me know if need more tests.

hthetiot commented 4 years ago

Thank you @numerized, you can test 7.0.0-RC3 based on 6.0.12 changes if you want.

cordova plugin remove cordova-plugin-iosrtc --verbose cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#7.0.0-RC3 --verbose cordova platform remove ios --no-save cordova platform add ios@latest --no-save

hthetiot commented 4 years ago

Hopefuly your issue with TypeError: Cannot read property '1' of null via /extra/hooks/iosrtc-swift-support.js has been addressed.

hthetiot commented 3 years ago

@numerized M84 is available here https://github.com/cordova-rtc/cordova-plugin-iosrtc/pull/545

numerized commented 3 years ago

Hi @hthetiot, I still experience the bug, even if I follow strictly #545 instructions. Now by the way, I have this error with the default cordova plugin add cordova-plugin-iosrtc --variable MANUAL_INIT_AUDIO_DEVICE=TRUE

Thanks for your work, if you have any question ping me.


Cannot read property '1' of null
TypeError: Cannot read property '1' of null
    at getProjectName (/Users/redloko/00_Github/bandcast/plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js:36:53)
    at module.exports (/Users/redloko/00_Github/bandcast/plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js:137:17)
    at runScriptViaModuleLoader (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:181:32)
    at runScript (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:157:16)
    at /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:125:20
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
[ERROR] An error occurred while running subprocess cordova.```
numerized commented 3 years ago

this version works cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#7.0.0-RC2 --variable MANUAL_INIT_AUDIO_DEVICE=TRUE --verbose

hthetiot commented 3 years ago

this version works cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#7.0.0-RC2 --variable MANUAL_INIT_AUDIO_DEVICE=TRUE --verbose

@numerized Can you test https://github.com/cordova-rtc/cordova-plugin-iosrtc#7.0.0-RC3 please and let me know here. Thx.

numerized commented 3 years ago

Same issue with RC3:


Executing script found in plugin cordova-plugin-add-swift-support for hook "after_prepare": plugins/cordova-plugin-add-swift-support/src/add-swift-support.js
Executing script found in plugin cordova-plugin-iosrtc for hook "after_prepare": plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js
Cannot read property '1' of null
TypeError: Cannot read property '1' of null
    at getProjectName (/Users/redloko/00_Github/bandcast/plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js:35:56)
    at module.exports (/Users/redloko/00_Github/bandcast/plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js:131:17)
    at runScriptViaModuleLoader (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:181:32)
    at runScript (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:157:16)
    at /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:125:20```
hthetiot commented 3 years ago

Same issue with RC3:

Executing script found in plugin cordova-plugin-add-swift-support for hook "after_prepare": plugins/cordova-plugin-add-swift-support/src/add-swift-support.js
Executing script found in plugin cordova-plugin-iosrtc for hook "after_prepare": plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js
Cannot read property '1' of null
TypeError: Cannot read property '1' of null
    at getProjectName (/Users/redloko/00_Github/bandcast/plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js:35:56)
    at module.exports (/Users/redloko/00_Github/bandcast/plugins/cordova-plugin-iosrtc/extra/hooks/iosrtc-swift-support.js:131:17)
    at runScriptViaModuleLoader (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:181:32)
    at runScript (/usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:157:16)
    at /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/hooks/HooksRunner.js:125:20```

Arf I will fill an issue @numerized

hthetiot commented 3 years ago

@numerized Hum can you check you setup (NVM) or check Cordova version. Travis does not reproduce, can you provide node version ?

numerized commented 3 years ago 
$ node -v 
v10.21.0
$ cordova --version
10.0.0

I was on cordova9 last weeks, I'll try again with the 10.0.0 Thanks

hthetiot commented 3 years ago

@numerized

I never tried with Cordova 10, version 9 work perfectly. I think the error is due some data in your config.xml such as the app name. Try running the sample app here: https://github.com/cordova-rtc/cordova-plugin-iosrtc-sample

Please fill a separate issue for your error if you do reproduce with sample or can provide steps to reproduce.

hthetiot commented 3 years ago

Updated to M79

hthetiot commented 3 years ago

7.0.0 will not be released and instead 8.0.0 will be released directly. See https://github.com/cordova-rtc/cordova-plugin-iosrtc/issues?q=milestone%3A8.0.0+is%3Aclosed