search

cordova-rtc / cordova-plugin-iosrtc

Cordova iOS plugin exposing the WebRTC W3C API
MIT License
688 stars 341 forks source link

[Announcement] cordova-plugin-iosrtc Version 8.0.x notes #546

Closed hthetiot closed 2 years ago

hthetiot commented 4 years ago

Hello cordova-rtc users,

I will released cordova-plugin-iosrtc 8.0.0 but in the mean time 8.0.0 RC is available for testing.

The current work in progress is on the branch https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/8.0.0 and the PR is https://github.com/cordova-rtc/cordova-plugin-iosrtc/pull/545

Changelog Version 8.0.0

Test 8.0.0-RC

cordova plugin remove cordova-plugin-iosrtc --verbose cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#master --verbose cordova platform remove ios --no-save cordova platform add ios@latest --no-save

hthetiot commented 4 years ago

8.0.0-RC2

numerized commented 4 years ago

Hi Harold @hthetiot

testing it and having this at compile

Screenshot 2020-08-31 at 17 54 17

What should we do ?

hthetiot commented 4 years ago

It looks to me the hooks was not executed, try removing the plug-in and add again.

Travis has no issue building branch 8.0.0: https://github.com/cordova-rtc/cordova-plugin-iosrtc/pull/545

numerized commented 4 years ago

already tried quite a few times this before reporting. I can put previous versions without any problem.

I tried to update to Swift5 too, just to be sure. Doesn't help.

I'll try with the demo project you have I rolled back to cordova9 and same issue, I tried with node12 as well.

numerized commented 4 years ago

I tried with your IOS sample project, from scratch first install I get this:

Screenshot 2020-09-01 at 11 19 08
hthetiot commented 4 years ago

@numerized can you fill a separate issue with information requested. I'm not able to reproduce any of your issues. Notice that if you use cordiva-ios 6+ you need to remove WKWebView Plugin cause its builtin now.

hthetiot commented 4 years ago

@numerized As you can see here Travis build without issue, meaning the issue in on your setup nothing else.

hthetiot commented 4 years ago

I tried with your IOS sample project, from scratch first install I get this:

Screenshot 2020-09-01 at 11 19 08

That because you are using cordova-ios 6+ you need to remove to cordova-plugin-wkwebview-engine when you use cordova-ios 6+

cordova plugin remove cordova-plugin-wkwebview-engine

numerized commented 4 years ago

I checked in depth and I found that my project was on swift 4.0, switching it to swift 4.2 made it working.

numerized commented 4 years ago

now when it comes to publishing in the appstore we face this bug:

Screenshot 2020-09-11 at 00 29 57

I've obviously updated to latest Xcode version and I usually don't have problems.

I usually follow these steps before publishing to appstores:

node plugins/cordova-plugin-iosrtc/extra/ios_arch.js --extract
node plugins/cordova-plugin-iosrtc/extra/ios_arch.js --device
node plugins/cordova-plugin-iosrtc/extra/ios_arch.js --clean
cordova platform remove ios
cordova platform add ios
file platforms/ios/Bandcast/Plugins/cordova-plugin-iosrtc/WebRTC.framework/WebRTC

which gives:

platforms/ios/Bandcast/Plugins/cordova-plugin-iosrtc/WebRTC.framework/WebRTC: Mach-O universal binary with 2 architectures: [x86_64:Mach-O 64-bit dynamically linked shared library x86_64] [arm64]
platforms/ios/Bandcast/Plugins/cordova-plugin-iosrtc/WebRTC.framework/WebRTC (for architecture x86_64): Mach-O 64-bit dynamically linked shared library x86_64
platforms/ios/Bandcast/Plugins/cordova-plugin-iosrtc/WebRTC.framework/WebRTC (for architecture arm64):  Mach-O 64-bit dynamically linked shared library arm64
cordova build ios --device
numerized commented 4 years ago

I could rollback to 7.0.0 RC2. Tomorrow I'll check and let you know

hthetiot commented 4 years ago

@numerized please fill separate issue, this is Announcement, not hotline or bug report issue.

Finaly google is your friend:

The documentation is your friend also:

platforms/ios/Bandcast/Plugins/cordova-plugin-iosrtc/WebRTC.framework/WebRTC (for architecture x86_64): Mach-O 64-bit dynamically linked shared library x86_64 platforms/ios/Bandcast/Plugins/cordova-plugin-iosrtc/WebRTC.framework/WebRTC (for architecture arm64): Mach-O 64-bit dynamically linked shared library arm64

You still have x86_64, this should not be the case...

hthetiot commented 3 years ago

Updated to m87 @numerized see

cordova plugin remove cordova-plugin-iosrtc --verbose cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/8.0.0 --verbose cordova platform remove ios --no-save cordova platform add ios@latest --no-save

Use WebRTC 4280 super fresh: https://webrtc.googlesource.com/src.git/+log/refs/branch-heads/4280

Reference: https://chromiumdash.appspot.com/branches

hthetiot commented 3 years ago

note: I also restoted i368 and armv7

hthetiot commented 3 years ago

8.0.0 will be next release, we skip 7 and 6 goes in LTS.

wmwood commented 3 years ago

I keep having this issue:

> cordova plugin add "https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/8.0.0" --verbose
No scripts found for hook "before_plugin_add".
Calling plugman.fetch on plugin "https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/8.0.0"
Failed to fetch plugin https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/8.0.0 via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
CordovaError: Error: command failed
CordovaError: Failed to fetch plugin https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/8.0.0 via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
CordovaError: Error: command failed
    at /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:140:43
hthetiot commented 3 years ago

@wmwood

I keep having this issue:

> cordova plugin add "https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/8.0.0" --verbose
No scripts found for hook "before_plugin_add".
Calling plugman.fetch on plugin "https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/8.0.0"
Failed to fetch plugin https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/8.0.0 via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
CordovaError: Error: command failed
CordovaError: Failed to fetch plugin https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/8.0.0 via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
CordovaError: Error: command failed
    at /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:140:43

Please create a separate issue this is not the right place, also Continuous integration does not have this issue (https://travis-ci.org/github/cordova-rtc/cordova-plugin-iosrtc/jobs/761038140), make sure to provide all version and exact steps to reproduce and dependency (ionic or capacitor, etc..).

Also we don't use "before_plugin_add" check plugin.xml, and finally, 8.0 is on master now

hthetiot commented 3 years ago

I keep having this issue:

> cordova plugin add "https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/8.0.0" --verbose
No scripts found for hook "before_plugin_add".
Calling plugman.fetch on plugin "https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/8.0.0"
Failed to fetch plugin https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/8.0.0 via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
CordovaError: Error: command failed
CordovaError: Failed to fetch plugin https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/8.0.0 via registry.
Probably this is either a connection problem, or plugin spec is incorrect.
Check your connection and plugin name/version/URL.
CordovaError: Error: command failed
    at /usr/local/lib/node_modules/cordova/node_modules/cordova-lib/src/plugman/fetch.js:140:43

Did you even read the error ?

Failed to fetch plugin https://github.com/cordova-rtc/cordova-plugin-iosrtc#task/8.0.0 via registry. Probably this is either a connection problem, or plugin spec is incorrect. Check your connection and plugin name/version/URL.

task/8.0.0 has been merged on master anyway.

I can believe i have to quote your error message to explain to you the issue.

@wmwood

hthetiot commented 3 years ago

If you want to test v8 read the testing, it's on master now and task/8.0.0 has been merged...

buu700 commented 3 years ago

8.0.0 is now latest on NPM.

Was it unpublished or something? I still see 6.0.20 as the latest version.

hthetiot commented 3 years ago

8.0.0 is now latest on NPM.

Was it unpublished or something? I still see 6.0.20 as the latest version.

Yes sorry about that, we went back to 6.0.20 for now we need more testing, i found a possible issue.

hthetiot commented 3 years ago

See https://github.com/cordova-rtc/cordova-plugin-iosrtc/issues/687#issuecomment-928111099