cordova-rtc / cordova-plugin-iosrtc

Cordova iOS plugin exposing the WebRTC W3C API
MIT License
690 stars 338 forks source link

RTCRtpSender not have DTMF properties and createDTMFSender deprecate #739

Closed buckun closed 2 years ago

buckun commented 2 years ago

YOU MUST read first!

Please use Community Forum for general technical discussions and questions.

Note: If the checkboxes above are not checked (which you do after the issue is posted), the issue will be closed, removing this checkbox will result in automatic closed issue.

Versions affected

Description

Steps to reproduce

Expected results

Actual results

Screen Shot 2022-02-10 at 20 49 02 Screen Shot 2022-02-10 at 21 23 18
hthetiot commented 2 years ago

PR welcome, alternatively shim around old API createDTMFSender in the meantime time.

hthetiot commented 2 years ago

May be you can update https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/master/js/RTCRtpReceiver.js with following changes this should works, then you make a PR and contribute, instead of complaining about specs implementation and ignoring my previous reply.

var RTCDTMFSender = require('./RTCDTMFSender'); ... RTCRtpSender.prototype.dtmf = function() { return RTCDTMFSender(this._pc, this.track) };

hthetiot commented 2 years ago

Fixed by #743 will add version number here once released

hthetiot commented 2 years ago

Version 8.0.2 fix this.