search

cordova-rtc / cordova-plugin-iosrtc

Cordova iOS plugin exposing the WebRTC W3C API
MIT License
688 stars 340 forks source link

PluginRTCPeerConnection: WebRTC >=m93 asserts on access to pc #756

Closed RSATom closed 2 years ago

RSATom commented 2 years ago

from signaling thread with debug WebRTC library on iOs device.

hthetiot commented 2 years ago

My understanding is that it put callback calls in a separate thread right ?

LGMT.

Thank you so much for maintaining iosrtc and give your code back as contributions.

hthetiot commented 2 years ago

@RSATom you mention M93, does that mean is required update of webrtc lib to be released since master use m87 ?

RSATom commented 2 years ago

My understanding is that it put callback calls in a separate thread right ?

yes, now pc uses the same DispatchQueue as iosrtc plugin itself. And it moves all stuff from signaling thread to thread owned by that DispatchQueue.

@RSATom you mention M93, does that mean is required update of webrtc lib to be released since master use m87 ?

no, it's not mandatory. m93 just started to assert about using signaling thread. But patch itself should be safe with any version.

hthetiot commented 2 years ago

Wonderful thank you, will release with another incoming PR soon.