cordova-rtc / cordova-plugin-iosrtc

Cordova iOS plugin exposing the WebRTC W3C API
MIT License
690 stars 338 forks source link

fix getProjectName() when config.xml:name has an attribute #757

Closed dcrousset closed 2 years ago

hthetiot commented 2 years ago

Hello @dcrousset thank you for your contribution. I have to double check because in the past I think this regexp was like that but then was changed because it caused issue. Unless I find old issue about it I will merge.

hthetiot commented 2 years ago

I will check for #597 regression before merging.

dcrousset commented 2 years ago

Hey @hthetiot

597 seems to be another problem. In our situation, we have an argument within our name tag, like this :

<name short="short">long name</name>

Thanks.

hthetiot commented 2 years ago

Thank you for replying with use case, I'm always cautious with RegExp for xml parsing, specially with ".*", I need a bit more time to validate some other issue we had with that line and if it too risky will use a DomParser instead.

Thank you for your understanding.