search

core-interaction-lab / assignments-seraaks

assignments-seraaks created by GitHub Classroom
0 stars 0 forks source link

Assignment 1 feedback #1

Open mauslerm opened 2 years ago

mauslerm commented 2 years ago

Please use the below validators to find and fix all errors and warnings in your code. You can copy the code from your editor, paste into the text box on the site, and click the Check button to see your results. Adjust your code and continue using the validator until no errors remain.

You're also missing a link with a relative URL on each of your pages. You can link each page to the other.

seraaks commented 2 years ago

Hi! I fixed my errors and my relative url's to the correct way. Hopefully this is all good. Thank you!

mauslerm commented 2 years ago

Hey Sera, it doesn't look like you pushed your changes to Github so I can't see them. Please commit and sync your files in Visual Studio Code so I can review, thanks!

seraaks commented 2 years ago

Hi Michael, When I try to push the changed sites it has the red error that says "Failed to execute git", and it wont let me create the pull request. Am I doing it completely wrong? During my class today I can ask a friend and try to get some help and hopefully I can, and if not can I show it to you on Friday? Thank you, Sera

On Tue, Feb 15, 2022 at 12:38 PM mauslerm @.***> wrote:

Hey Sera, it doesn't look like you pushed your changes to Github so I can't see them. Please commit and sync your files in Visual Studio Code so I can review, thanks!

— Reply to this email directly, view it on GitHub https://github.com/core-interaction-lab/assignments-seraaks/issues/1#issuecomment-1040573524, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXOP2FT56NYLOZGJQC6WO3TU3KFQJANCNFSM5NTAMNIA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were assigned.Message ID: @.***>

mauslerm commented 2 years ago

Ok I'll take a look on Friday

seraaks commented 2 years ago

Hi! I committed everything with your help, so the updated versions should be there for you to see. Thank you again. Sera