search

core-interaction-lab / e_art

assignments-wangy716 created by GitHub Classroom
0 stars 0 forks source link

Assignment 2 feedback #2

Open mauslerm opened 2 years ago

mauslerm commented 2 years ago

Your site looks good, I think the only requirement you are missing are hsl CSS color values, and you could probably apply BEM classes to the items on aboutpage.html. The HTML validator caught 2 stray closing tags on the news and about pages. Also cant see the submenu items on the about page because they are white and the background is white. To improve the site on mobile devices you could increase the font size of your navigation menus with media queries.

wangy716 commented 2 years ago

I will add hsl css color values, correct the closing tags on the news and about page, and increase font size on mobile version. I intentionally make the submenu white on the widescreen.

wangy716 commented 2 years ago

added HSL color; closed tags for apply and news pages; changed submenu color