coredns / coredns

CoreDNS is a DNS server that chains plugins
https://coredns.io
Apache License 2.0
12.35k stars 2.13k forks source link

coredns_proxy_healthcheck_failures_total is not available in coredns:v1.11.1 #6929

Open lesage-oded opened 1 week ago

lesage-oded commented 1 week ago

What happened: using coredns:v.1.11.1 docker image and coredns_proxy_healthcheck_failures_total is not being emitted as a metric

What you expected to happen: According to the README https://github.com/coredns/coredns/blob/c8829a63b9fb611185a0ee5f00aaa9aad1095929/plugin/forward/README.md?plain=1#L134

coredns_proxy_healthcheck_failures_total is the replacement for deprecated coredns_forward_healthcheck_failures_total

How to reproduce it (as minimally and precisely as possible): curl the metrics endpoint and grep for coredns_proxy_healthcheck_failures_total, which comes back empty

Anything else we need to know?: We were using coredns_forward_healthcheck_failures_total but this has been deprecated, it's replacement coredns_proxy_healthcheck_failures_total is not available

Environment:

Granther commented 5 days ago

It appears that coredns_proxy_healthcheck_failures_total is only emitted when CoreDNS is unable to successfully perform a health check on the upstream proxy servers. From my testing, when I disconnected CoreDNS from accessing its configured upstream servers, the health check failure metric populated as expected. Please correct me if I'm mistaken.