search

coredns / deployment

Scripts, utilities, and examples for deploying CoreDNS.
Apache License 2.0
549 stars 535 forks source link

Run make with -e so users can override makefile variables #278

Closed kaysond closed 2 years ago

kaysond commented 2 years ago

Fixes #267

chrisohaver commented 2 years ago

@utkonos, Do you have any concern for the existing variables being somewhat generic? For example VERSION is more likely to be already in use on a system than something like DPKG_COREDNS_VERSION

utkonos commented 2 years ago

That is a good point. There is no reason the variables used here can't be more unique rather than more generic. Making them more unique would prevent a collision with a potentially common variable like VERSION. I think that's a good modification. @kaysond can you make that edit to the PR?

kaysond commented 2 years ago

Done! I changed VERSION and DISTRIBUTION since that also seemed like one that might be set errantly.

Tested the build on latest and 1.9.1.

utkonos commented 2 years ago

I tested it as well. Looks like it works for current and old versions via dpkg-buildpackage -us -uc -b.

@chrisohaver Are there any other build methods or pathways that should be tested? The above is the only one I'm setup for.

chrisohaver commented 2 years ago

Thanks all!