coredns / fallback

The fallback plugin allows sending queries to alternate upstreams based on rcodes returned from the plugin chain.
Apache License 2.0
12 stars 17 forks source link

code returned by fallback.ServeDNS is not correct one #4

Closed fturib closed 6 years ago

fturib commented 6 years ago

When fallback rules are not kicked-in, the cored return by ServeDNS is not the right one: => it should be the rcode returned by the following handler, not a combination of that rcode and the rcode returned by the Response.

Was discovered while trying to log the DNS messages and found that FALLBACK plugin had an influence on these logs although none of the rules of FALLBACK was hit.