search

coredns / fallback

The fallback plugin allows sending queries to alternate upstreams based on rcodes returned from the plugin chain.
Apache License 2.0
12 stars 17 forks source link

code returned by fallback.ServeDNS is not correct one #5

Closed mparamonau closed 6 years ago

codecov-io commented 6 years ago

Codecov Report

Merging #5 into master will increase coverage by 8.88%. The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #5      +/-   ##
==========================================
+ Coverage   68.88%   77.77%   +8.88%     
==========================================
  Files           2        2              
  Lines          45       45              
==========================================
+ Hits           31       35       +4     
+ Misses          9        7       -2     
+ Partials        5        3       -2
Impacted Files Coverage Δ
fallback.go 78.94% <87.5%> (+21.05%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c399c45...208fa90. Read the comment docs.

fturib commented 6 years ago

fixing #4

fturib commented 6 years ago

@johnbelamaric : Could you merge this PR ?