search

coredns / helm

Helm Charts for CoreDNS
Apache License 2.0
108 stars 111 forks source link

Please support configuring environment variables for the cluster-proportional-autoscaler container #151

Open stevo-f3 opened 12 months ago

stevo-f3 commented 12 months ago

E.g. to enable configuring Go runtime with GOMAXPROCS and GOMEMLIMITS environment variables.

Optionally, consider setting GOMAXPROCS and GOMEMLIMITS env vars automatically relative to the configured resources (CPU requests, and memory limits, respectively), when resources are configured.

With current default resource configuration (20m CPU requests and limits) and no GOMAXPROCS configured, there's lots of CPU throttling. Upstream chart doesn't set default resource configuration, so partially issue could be solved with https://github.com/coredns/helm/issues/103 - at least it would move upstream.

hagaibarel commented 11 months ago

I understand your point, but at this point I wouldn't want to make any changes until we get #103 done