coredns / helm

Helm Charts for CoreDNS
Apache License 2.0
108 stars 111 forks source link

Allow to skip ConfigMap creation #167

Closed cep21 closed 5 months ago

cep21 commented 6 months ago

Why is this pull request needed and what does it do?

A requested rebase and merge from PR #41

Which issues (if any) are related?

Checklist:

Changes are automatically published when merged to main. They are not published on branches.

Note on DCO If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the *Details* link next to the DCO action for instructions on how to resolve this.
cep21 commented 6 months ago

Hi @hagaibarel , this is the rebased PR

hagaibarel commented 5 months ago

@cep21 I think the last commit wasn't properly signed-off, please fix

cep21 commented 5 months ago

@cep21 I think the last commit wasn't properly signed-off, please fix

Fixed!

hagaibarel commented 5 months ago

@cep21 great job, thanks for working on this