search

coredns / rfc

Propsals and request for comments for CoreDNS
0 stars 11 forks source link

Adding my GSoC proposal for review #3

Closed wjayesh closed 4 years ago

yongtang commented 4 years ago

/cc @greenpau

greenpau commented 4 years ago

@yongtang , do you have the ability to add me as a reviewer here?

@WJayesh , please complete DCO.

yongtang commented 4 years ago

@greenpau I don't have the access as well.

@miekg can you add me and @greenpau to the reviewer of this PR?

miekg commented 4 years ago

[ Quoting notifications@github.com in "Re: [coredns/rfc] Adding my GSoC pr..." ]

@greenpau I don't have the access as well.

@miekg can you add me and @greenpau to the reviewer of this PR?

I've clicked a thing. Seems this is new in Github or so ?

yongtang commented 4 years ago

@miekg Ah now it works. Think GitHub might have changed some UI/UX recently.

greenpau commented 4 years ago

@miekg Ah now it works. Think GitHub might have changed some UI/UX recently.

@miekg , @yongtang , I don't have the ability to assign myself as "reviewer".

yongtang commented 4 years ago

@greenpau I am not sure. I can assign me but can not assign you as reviewer. Guess it might be a GitHub issue.

rajansandeep commented 4 years ago

It seems that we can only assign people from https://github.com/orgs/coredns/people

yongtang commented 4 years ago

@rajansandeep but the same is not true for https://github.com/coredns/coredns repo? Guess there might be some difference there.

miekg commented 4 years ago

[ Quoting notifications@github.com in "Re: [coredns/rfc] Adding my GSoC pr..." ]

It seems that we can only assign people from https://github.com/orgs/coredns/people

yeah, this repo seems off, but I though anything under the coredns org would work the same, apparently GitHub "fixed" something and now things are different. #sigh

wjayesh commented 4 years ago

@yongtang @greenpau I want to discuss an addition to this project idea. I have been following the discussion on the ML model training on the issue thread and assisting Chanakya with the cloud and CoreDNS side of things for the past few days. I want your thoughts on the following:

  1. The health check binary can expose a port to listen to incoming queries. Whenever the model detects a (memory/usage related) anomaly condition - instead of informing the on-call engineer directly- can it first send a notification to the binary which can confirm the outage of the pods?
    • This will help prevent false alarms
    • Allow the model to learn better based on the feedback from the binary.
  2. In Zalando's case, the pods kept running OOM and getting killed. Keeping this in mind, I propose a notification service in the binary which will trigger if the pods get unresponsive in quick succession (after the every restart). This is because such a situation is out of control for the health check binary and would require human intervention (like increasing memory limit).
  3. It was mentioned in the thread that in case of an anomaly, it is best if the model could restart the pods (in addition to informing the engineer). Won't the health check binary already do so whenever the pods stop responding appropriately? In any case, the restarting functionality can also be forwarded to the binary to reduce redundancy.
wjayesh commented 4 years ago

I hope everybody's well and safe. I just wanted to know if there are any changes/modifications that I could make to the proposal and any feedback on what I've written above. Thanks!

yongtang commented 4 years ago

@WJayesh Sorry for the late reply. Will try to take a look this week. Hope everyone is well 👍

wjayesh commented 4 years ago

@yongtang @greenpau Hi! Hope you're well and healthy. I learnt that this project idea that I applied for, sadly, didn't get selected for GSoC this year. Can you please help me know what were the shortcomings on the same? This will really help me introspect; I had done a lot of research and experimentation with the idea and put in my best efforts for the proposal. Knowing what I did wrong would help me better prepare for projects in the future. Thank you :)

greenpau commented 4 years ago

Can you please help me know what were the shortcomings on the same?

@WJayesh , I don't think ideas have shortcomings, because for that you have to experience them :smile: Your idea is not an exception. The GSoC selected one project and your's was not selected because there was another one where the interests of mentors and the proposal optimally matched. This year there were 2 projects: tooling and deep learning.

note: There are many different ways to look at a "thing", i.e. many angles. It also depends on the perspectives of actors.

Here is one reflection on this. Say you have an essay to write ... Your professor offers you 3 topics ... your choice. Which topic do you choose? The one you are most familiar with? The one that is straightforward to implement? The one your professor is doing research on? ... That's only one perspective.

Life is one big competition ... set your own framework. Learn how to innovate without a framework of GSoC or other organization. That's my own perspective.

yongtang commented 4 years ago

👍 for @greenpau 's comment. In addition to that, I do want to mention that CoreDNS is also participating in CommunityBridge sponsored by Linux Foundation:

https://github.com/coredns/rfc/issues/7

CommunityBridge sponsored by Linux Foundation program is a similar program to Google's Summer-of-Code. Each year a set of students are selected to work on an open source program. Upon successful completion, Linux Foundation will pay stipend to student in a similar way.

yongtang commented 4 years ago

This year's CoreDNS candidate project for CommunityBridge sponsored by Linux Foundation is in this link.

greenpau commented 4 years ago

This year's CoreDNS candidate project for CommunityBridge sponsored by Linux Foundation is in this link.

@WJayesh , you see :-) That's life! One door closes and another opens up! :-)

@yongtang, :+1: good one :smiley:

wjayesh commented 4 years ago

@greenpau Thank you for the thoughtful response. I agree with you on looking at the big picture and the need to keep innovating and working, beyond individual events. I'll go set some personal open-source contributions goals to hit when things don't work out :)

wjayesh commented 4 years ago

you see :-) That's life! One door closes and another opens up! :-)

Yes! This brought a smile to my face :-)
A lot to learn!

yongtang commented 4 years ago

@WJayesh Thanks for your proposal and sorry for the late reply. As was discussed, after internally review and coordinating with admins, another proposal has been accepted. We do appreciate your contribution and involvement.

I will close this PR, but we welcome you submit proposals in the future for either CommunityBridge or GSoC! And as you could see, CommunityBridge Program is upcoming next!