search

coredns / rrl

Response Rate Limiting Plugin for CoreDNS
Apache License 2.0
23 stars 21 forks source link

Register `rrl` directive automatically #26

Closed AleksandrIakhnev closed 3 years ago

AleksandrIakhnev commented 3 years ago

Use Case:

To use rrl plugin from node-cache tool https://github.com/kubernetes/dns/blob/master/cmd/node-cache/main.go

If I try to use rrl plugin from master with node-cache it does not parse Corefile with an error "Error during parsing: Unknown directive 'rrl'"

chrisohaver commented 3 years ago

Thank you, although this isn't the right place for this. In CoreDNS, Directives is automatically generated at build time using the /plugin.cfg file. IOW, when one wants to add the rrl plugin, they would add it to plugin.cfg in the desired execution order, and then run make. See https://coredns.io/2017/07/25/compile-time-enabling-or-disabling-plugins/

chrisohaver commented 3 years ago

Also see here: https://github.com/coredns/rrl#external-plugin ... regarding the recommended execution order placement of rrl relative to other plugins.

AleksandrIakhnev commented 3 years ago

@chrisohaver Any ideas when this plugin will be included to the default plugins list distribution?

chrisohaver commented 3 years ago

@chrisohaver Any ideas when this plugin will be included to the default plugins list distribution?

There are currently no plans for merging this plugin into coredns as a default plugin.

AleksandrIakhnev commented 3 years ago

@chrisohaver thanks for the answers