search

coredns / rrl

Response Rate Limiting Plugin for CoreDNS
Apache License 2.0
23 stars 21 forks source link

Response Truncation (slip-ratio) #32

Closed lara closed 2 years ago

lara commented 2 years ago

hey there, are there any plans to provide an option to truncate responses instead of dropping them?

chrisohaver commented 2 years ago

It's identified in the design spec, https://github.com/coredns/rrl/blob/master/README-DEV.md#slip-ratio, but it is not implemented, no work has begun on it.

Is this something you want to implement? If not, I can start on it.

lara commented 2 years ago

oh nice, I missed that. I'd be happy to work on it.

chrisohaver commented 2 years ago

@lara, have you had time begin on this yet? If not, I can probably knock it out pretty quickly.

chrisohaver commented 2 years ago

@lara, please see #35, for my implementation of this feature.

lara commented 2 years ago

@chrisohaver thank you for implementing the feature, life got in the way for me