Date related fixes - Githubissues

coregis / cbf-programs-map-2023

Rebranding and other updates to the Raise Your Hand Texas Programs Map

GNU General Public License v3.0

0 stars 0 forks source link

Date related fixes #14

Closed eldang closed 11 months ago

eldang commented 11 months ago

Resolves #11

Also fixes two small things I noticed while doing that:

There wasn't any validity checking on the URL parameters, so setting &year=banana would break the time slider, and setting &year=1900 would give us a blank map.
A subtle timing bug that made it possible for the year in the URL params & page title to fall out of sync with what was actually being displayed on the map and time slider.

eldang commented 11 months ago

Note that when I test this locally, I don't see any data changes going from 2021 to 2023. I'm hoping this is just a caching issue, but it will be worth rechecking once we have it on Github Pages.

coregis commented 11 months ago

There wasn't any validity checking on the URL parameters, so setting &year=banana would break the time slider, and setting &year=1900 would give us a blank map.

The Year of the Banana sounds a bit like a rare but very interesting and delicious cultural tradition from somewhere in Central America