search

coregis / cbf-programs-map-2023

Rebranding and other updates to the Raise Your Hand Texas Programs Map
GNU General Public License v3.0
0 stars 0 forks source link

Attribution fixing mrs *CAUTION* #26

Closed coregis closed 9 months ago

coregis commented 9 months ago

This resolves the final item in #17 HOWEVER when I switched out the source of the invisible school_house_senate_districts_UNION layer from core-gis to web-charlesbuttfdn Mapbox accounts, it appears to have broken the point filtering by ESC Region, even though the boundaries still display, zoom-to works, etc.

eldang commented 9 months ago

Oh dear! I'll look into that right after emailing EPRI.

eldang commented 9 months ago

Sorted! The main issue was actually just that I needed to merge the main branch into this one to get the latest changes. I did make a couple of other small tweaks, which I'll explain in comments.

coregis commented 9 months ago

@eldang and @nein09 I think this PR gets us through all of the revisions per the rolling CBF agenda, are the two of you cool with merging this PR, then I will send the GitHub pages link to Kurt, Joel et al tomorrow morning? Or do either/both of you have any remaining changes you would like to make?

eldang commented 9 months ago

I support that!

I do think that the free text entry search for school districts was also on the list, but it seems perfectly reasonable to either hold that for phase 2, or just send the current state of things to Kurt and tell him I'm still working on that feature. I think it's realistic for me to get it done this week, but I'm not convinced it's worth waiting until it's done to show CBF the rest of our progress and get their feedback.

coregis commented 9 months ago

I support that!

I do think that the free text entry search for school districts was also on the list, but it seems perfectly reasonable to either hold that for phase 2, or just send the current state of things to Kurt and tell him I'm still working on that feature. I think it's realistic for me to get it done this week, but I'm not convinced it's worth waiting until it's done to show CBF the rest of our progress and get their feedback.

OK! Currently the dropdown seems to support a limited version of the auto-complete described in #13 so I am comfortable sending the map as-is and let CBF know you're planning to finish the more nuanced version of that functionality. Gonna merge this.