prefer system spicyz (fix for Zeek v5) and don't unset C++ toolchain variables - Githubissues

corelight / zeek-spicy-stun

A Zeek STUN protocol analyzer based on Spicy.

BSD 3-Clause "New" or "Revised" License

4 stars 2 forks source link

prefer system spicyz (fix for Zeek v5) and don't unset C++ toolchain variables #5

Closed mmguero closed 2 years ago

mmguero commented 2 years ago

build_command should check for system spicyz before falling back to spicy-plugin/build/bin/spicyz (allows plugin to work with Zeek v5.0.0's built-in spicy plugin, see https://github.com/zeek/spicy-ldap/blob/06690d5f82598b127a491314e314a6d17d1ca082/zkg.meta#L6=); and, allow customization of C++ toolchain via canonical environment variables (see https://github.com/zeek/spicy-ldap/commit/06690d5f82598b127a491314e314a6d17d1ca082)

Tested install with Zeek v5.0.0 (with integrated spicy) and Zeek v4.2.2 (with spicy deb and zkg-installed zeek spicy-plugin).

Signed-off-by: Seth Grover mero.mero.guero@gmail.com

keithjjones commented 2 years ago

@mmguero you rock, thank you!