coremedia-contributions / blueprint-svg-support

0 stars 0 forks source link

Display of the SVG thumbnail does not fit #5

Open stevenfricke opened 4 months ago

stevenfricke commented 4 months ago

Hi,

I adapted the code for a client to create a custom document type which should do the same like CMSVG. In the studio form I have the problem, that the display of the thumbnail for the svg isn't working properly.

image

The SVG I used is this: data

Since I'm not very familiar with frontend development, I'm asking here how I can fix this.

Best regards, Steven

fwienber commented 4 months ago

Hi Steven, in the standard Blueprint, there is no CMSVG type and you cannot upload SVGs into a "Picture" document, but only into a "Technical Image" or "Download" document. There, the SVG does not have any preview. So it seems you already customized something to make the SVG appear. Can you please share which property field you customized (probably BlobPropertyField), and how?

stevenfricke commented 4 months ago

Hi Frank,

I refer to the CMSVG document type from this repository https://github.com/coremedia-contributions/blueprint-svg-support/blob/cmcc-11-2310/svg-doctypes/src/main/resources/framework/doctypes/svg-plugin/svg-doctypes.xml .

The property field which is used here is this one https://github.com/coremedia-contributions/blueprint-svg-support/blob/cmcc-11-2310/apps/studio-client/apps/main/svg-studio-plugin/src/fields/ExtendedBlobPropertyField.ts .

fwienber commented 4 months ago

Ah, sorry, my bad, I stumbled across your question out of context, but looking at where you posted it this all makes much more sense to me now! Also sorry I cannot give any practical advise, but I'm sure @sbuettne, @seckhors or @pitgrap can.

sbuettne commented 4 months ago

Hi Steven,

Seems as if this is an issue only occurring in CMCC 11. In CMCC 12, I was not able to reproduce it with your test SVG. As a workaround, you can try to add the following CSS to the svg-studio-plugin.css:

.cm-blob-property-field-blob .x-container-frame img.x-component {
  width: 100%;
}