Shall we return Yang Property[] in List.change?

corenova / yang-js

YANG parser and composer

Apache License 2.0

56 stars 18 forks source link

Shall we return Yang Property[] in List.change? #98

Closed quantang closed 4 years ago

quantang commented 5 years ago

Hi @saintkepha,

I know that you added the List.change property to return the newly created list items. Right now, it returns the pure JS objects. I am thinking whether it would be more useful if we return them as a Property list, which could give us more information than the pure JS object, such as the List item key.

Cheers.

sekur commented 4 years ago

Recent change to use Proxy objects now returns an array of Proxy objects for List.change which provides abstraction to access other useful information. Also, List.changes now directly return ListItem properties.