search

corentinaltepe / nlog.loki

NLog target for Loki using an HTTP client
BSD 3-Clause "New" or "Revised" License
22 stars 7 forks source link

[Feature Request] optional proxy settings #41

Closed erSitzt closed 1 year ago

erSitzt commented 2 years ago

Hi,

as HttpClient is used for Loki it would be nice to add proxy support as many corporate networks still rely on proxies.

These two support proxies https://github.com/AlanBarber/NLog.Targets.Splunk https://github.com/DarekDan/NLog.Targets.HTTP

corentinaltepe commented 2 years ago

Hello @erSitzt, thank you for your proposal.

Given HttpClient supports proxy, see documentation here, that'd be great to pass proxy configuration to the client.

We'd likely need two or three properties, right?

Would you feel like submitting a PR to add that feature?

erSitzt commented 2 years ago

@corentinaltepe I'm more of a "hobbyist" c# guy :) if i find the time i can try.. but it might need some refurbishment afterwards ;)

corentinaltepe commented 2 years ago

Thanks a lot. I'm ready to help and complete the pr with unit tests if needed.

corentinaltepe commented 1 year ago

Hi @erSitzt, over a year later but the feature is available starting v1.5.0.