search

corentingosselin / ProdigyCape

prodigycape is the most realistic cape plugin for your minecraft server
https://www.spigotmc.org/resources/prodigycape-1-19-4-1-20-6-opensource.116899/
11 stars 6 forks source link

ProtocolLib?? #6

Closed max1mde closed 4 months ago

max1mde commented 4 months ago

First of all.. Really cool plugin & idea

But why make it so complicated by using ProtocolLib and NMS? Its harder and takes more time to update such a project.

Please switch to Packet Events: https://github.com/retrooper/packetevents

And Entity Lib: https://github.com/Tofaa2/EntityLib

Why these two libraries? Because you don't have to think about version depending stuff (You only have to update the libraries when a new MC version comes out, not the source code in most cases) also with these libraries combined, its as easy to work with packets as with the normal bukkit api.

If you do so, I will probably contribute to this project too! If not I could maybe create a pull request for the changes...

Some other stuff

(Wrong it's 1.19.4) image

Ideas

I've also got some additional feature ideas:

corentingosselin commented 4 months ago

Hello !

Thank you for the feedback 👍 I appreciate fresh ideas and tools

Unfortunately we must use nms and packet to do that, when I first started the plugin I used bukkit display entities. The plugin was working fine with that. And after more test, I found a big issue. You cannot teleport a player with a passenger. This is so crazy in minecraft code that the only way to fix that is by using packet. This means that you literally break all server with teleport plugin features.

You read in my mind, I wanted to use a lib like you just mentioned, but most of them was outdated or not working properly. And honestly I did not know this one. So yes let's remove protocollib !

However, not sure about entitylib. The cape transformation system is a bit tricky depending the version so I should keep native nms usage

You're right for 1.19.4, I was dizzy between minecarft version and nms R4

I had a similar idea:

Java api of course, but I'm too lazy to do that xD

max1mde commented 4 months ago

Okay so... You are right with the teleportation... I've had this issue too with my chat bubbles plugin (https://www.spigotmc.org/resources/115811/)

But with packet events & entity lib it does work because its also a packet lib like protocollib just in better and actively maintained.

Also I already wrote a plugin like a year ago for hat cosmetics using item displays (Not packet based) with serverside calculated rotation: image So its defenetly possible to add different types of cosmetics... But it has some problems....

Also I can prob. implement the java api.

corentingosselin commented 4 months ago

Nice I will start the migration to packet events lib. I will try another migration with entity lib but I need to make sure that it does not break the current cape system.

Yes nice screenshot, this kind of idea should be another plugin with giant market place around every server. I bet someone is already starting this kind of project. This could be a massive business

max1mde commented 4 months ago

Okay nice!

And yes this is a really wanted plugin... I also wanted to publish mine

max1mde commented 4 months ago

Like there are many people who want such cosmetics like hats, capes wings... for their server without a resourcepack

corentingosselin commented 4 months ago

Okay nice!

And yes this is a really wanted plugin... I also wanted to publish mine

don't wait ! I will close this ticket, if you want to discuss more about the projects ect you can add me on discord: cocoraid