corentinlger / ER-MRL

Code for the "Evolving Reservoirs for Meta Reinforcement Learning" paper
MIT License
6 stars 2 forks source link

TradingEnv #4

Open ghost opened 2 months ago

ghost commented 2 months ago

I couldn't use TradingEnv (Action Space: Discrete(3)) please anyone can help me?

corentinlger commented 2 months ago

Hello, the algorithm supports Discrete action spaces, so the issue is probably coming from somewhere else.

Could you share the code and the error message to help identify the problem ?

ghost commented 2 months ago

Thanks for your answer yes the problem was from storage = JournalStorage(JournalFileStorage(log_name)) and I used : warnings.filterwarnings("ignore", category=optuna.exceptions.ExperimentalWarning) BTW the algorithm didn't work well do you think it's because I used fewer training time steps 25k with 25 trials? (because I'm using just 3500 lines of data) PPO: output1 PPO: TradingEnv with some parameters like (trading_fees & borrow_interest_rate): output2

Update: I changed the algorithm to DQN (50k 30 trials) then (1m training steps) :

dqnn

corentinlger commented 2 months ago

Ok nice if you fixed this bug.

As for performance, it can depend a lot on the specific problem, but here are a few tips:

Does that answer your question ?

ghost commented 2 months ago

No I have not used several reservoirs yet I was just testing I will take these notes into consideration. Thank you so much.

corentinlger commented 2 months ago

No problem, I'm curious to see what results you'll get (;

Can I close the issue @youssefaiths ?