search

coreos / airlock

Minimal update/reboot orchestrator for Fedora CoreOS clusters
Apache License 2.0
39 stars 9 forks source link

Add tls support and certificate authentication in interaction with etcd. #43

Closed davidprtgnzlz closed 1 year ago

davidprtgnzlz commented 2 years ago

Hello.

Yesterday I created a pull request and you added some very successful comments.

In this case, I have modified the libraries that I use and now use the same ones that the project already had, so there are no updates. I apologize for the oversight.

Do you consider the appropriate changes in this case?

Right now we have tested it and it works correctly.

Any other suggestion is welcome.

Thank you very much in advance.

davidprtgnzlz commented 2 years ago

This contribution resolves part of the issue: https://github.com/coreos/airlock/issues/7

davidprtgnzlz commented 2 years ago

Hello. How do you see now the changes I have made?

lucab commented 1 year ago

@davidprtgnzlz thanks for the rework, this now matches the logic that I was more or less expecting. Code looks good to me, I'm ok with merging this. Did you re-check that the current code still fully works as expected in your target environment?

davidprtgnzlz commented 1 year ago

Yes it works correctly, @lucab !!

lucab commented 1 year ago

Thanks for confirming and for working on this, merged!