Support updating multiple EFIs in mirrored setups

coreos / bootupd

Bootloader updater

Apache License 2.0

109 stars 21 forks source link

Open jlebon opened 3 years ago

jlebon commented 3 years ago

Follow-up to https://github.com/coreos/bootupd/pull/127 (specifically https://github.com/coreos/bootupd/pull/127#discussion_r546995248). We need to update the EFI in all the devices matching the appropriate GUID, not just the one which wins the /dev/disk/by-partlabel/EFI-SYSTEM race.

bgilbert commented 3 years ago

One small correction: in the mirrored boot disk case, no partitions are labeled EFI-SYSTEM.

jlebon commented 2 years ago

Note that just dumbly doing a type GUID match will not work for things like multipath. We solved this in rdcore by looking for ESPs only on the same devices which back the boot partition: https://github.com/coreos/coreos-installer/blob/78e2a7a4bf8d9ddb90b5e4fb5729a2550999ad11/src/blockdev.rs#L880-L945

Would probably make sense for bootupd to use the same heuristic (or if it finds a better heuristic to use, update coreos-installer to match).

travier commented 2 months ago

Notes for implementing this for Fedora CoreOS:

But unfortunately we might have to add more heuristics to support Anaconda installations.

travier commented 4 days ago

So Fedora CoreOS should be the only case with one per disk, unless someone use manual partitioning and explicitly set up two.